broken links with "--dir"

[leapfog]

'algernon --dir .' creates proper links to the files in the current folder, but 'algernon --dir ./' creates broken links: each linked file's first char has been removed. A file called "foo" is linked as "oo". I confirmed this with versions 1.12.5 and 1.12.6 on Linux.

[xyproto]

Thanks for reporting! I'll look into this and fix it.

[xyproto]

Bug confirmed, will fix.

[xyproto]

Fixed in master. Please test.

[leapfog]

The fix helps, current master doesn't create broken links anymore. Playing a bit around it seems that algernon doesn't cleanup/canonicalize rootdir, so a usage like "--dir $PWD/../../www/" unnecessarily exposes the (name of the) current working directory.

[xyproto]

Thanks for testing.

I created a branch named reldir, where the relative directory is used instead.

If it's an improvement, I'll merge it to master.

[leapfog]

I tested again with latest git, but the reldir modification does not (always) do what I had expected, see the following example:

$ mkdir -p dir1a/dir2a dir1a/dir2b/dir3

$ algernon.git --dir $PWD/dir1a/dir2a/../dir2b/dir3/./// --httponly --verbose

good: algernon shows "dir1a/dir2b/dir3/"
(maybe "dir3" or just "/" would be even better)

$ algernon.git --dir dir1a/dir2a/../dir2b/dir3/./// --httponly --verbose

bad: algernon shows "dir1a/dir2a/../dir2b/dir3/.//"