Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for 8MB SA-1/SDD-1 roms #23

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Added support for 8MB SA-1/SDD-1 roms #23

merged 2 commits into from
Sep 18, 2023

Conversation

TrashRaccoonSnuffy
Copy link
Collaborator

@TrashRaccoonSnuffy TrashRaccoonSnuffy commented Sep 11, 2023 •
edited
Loading

Solves #17

Changes:

  • Maxromspace is now 0xC00000 and no longer dynamic, the size of the ROM buffer has been bumped to 16MB from 6MB. The upper half is stored for storing special chip variables to conserve memory.
  • Backports a security update where SA-1 DMA could be used to execute arbitrary code.
  • Added ExLoROM mapper support

@TrashRaccoonSnuffy TrashRaccoonSnuffy merged commit 2a363e1 into xyproto:main Sep 18, 2023
@TrashRaccoonSnuffy
Copy link
Collaborator Author

Merging this because it appears to have no issues. Most SA-1 games are still unplayable due to incorrect conversion to C, but they boot atleast. Super Mario RPG will have to be fixed eventually.

@TrashRaccoonSnuffy TrashRaccoonSnuffy mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TrashRaccoonSnuffy