Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#20 Add Nim2.0 support #23

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

PhilippMDoerner
Copy link
Contributor

@PhilippMDoerner PhilippMDoerner commented Jan 21, 2023

Adds nim2.0 support, or at least I'll aim for a branch that's good enough to use in a norm fork for my own project. do with that as you will.

(Also see #22 which was the previous PR for this with a dummy branch, before I decided to make a temporary fork for myself until this is dealt with)

@PhilippMDoerner PhilippMDoerner changed the title Add Nim2.0 support #20 Add Nim2.0 support Jan 21, 2023
@PhilippMDoerner PhilippMDoerner changed the title #20 Add Nim2.0 support [WIP] #20 Add Nim2.0 support Jan 21, 2023
@PhilippMDoerner
Copy link
Contributor Author

So because nim 2.0 introduced strict effects and you made use of the effects system, I had to fix a few tag things.
I wasn't aware of it before, but std/times has the TimeEffect. This hadn't been accounted for before, so I fixed that.
Now I can compile norm docs with this branch without having RootEffects everywhere.

@PhilippMDoerner PhilippMDoerner changed the title [WIP] #20 Add Nim2.0 support #20 Add Nim2.0 support Jan 25, 2023
@PhilippMDoerner
Copy link
Contributor Author

PhilippMDoerner commented Jan 25, 2023

Anyway, I just checked out the tests for norm and made use of my branch here in norm, since I can get those tests to run.
Those tests run flawlessly for both sqlite and postgres, so I'll assume that ndb works well in general on this branch. Personally I consider the PR finished with that unless further editing suggestions are made.

@Clonkk
Copy link

Clonkk commented Apr 3, 2023

Any news on this ? With 2.0 around the corner it'd be nice to have it working

@PhilippMDoerner
Copy link
Contributor Author

Any news on this ? With 2.0 around the corner it'd be nice to have it working

I forked ndb and created lowdb, which is 2.0 ready.
https://github.com/PhilippMDoerner/lowdb

@Clonkk
Copy link

Clonkk commented Apr 3, 2023

My dependency of ndb comes from norm so it's not up to me but to @moigagoo. I don't know which is best for the 2.0 migration.

@PhilippMDoerner
Copy link
Contributor Author

Then you'll be glad to hear that norm jumped over to lowdb as of 2.7.0 via this PR:
moigagoo/norm#186

Here the announcement for it:
https://forum.nim-lang.org/t/6471#65566

@Clonkk
Copy link

Clonkk commented Apr 3, 2023

Then I guess it's my fault for not upgrading sooner :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants