Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Int128, UInt128, Int256 and UInt256 types #184

Merged
merged 4 commits into from
Aug 29, 2022

Conversation

akolov
Copy link
Contributor

@akolov akolov commented Jul 8, 2022

Added support for Int128, UInt128 and Int256, UInt256 types.

@xzkostyan
Copy link
Owner

Good. But build has failed. Will you make tests green?


@with_native_and_http_sessions
class Int128TestCase(BaseTestCase):
table = Table(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For skipping test for old server add to testcases:

required_server_version = (X, Y, Z)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added server version to tests.

@akolov
Copy link
Contributor Author

akolov commented Aug 29, 2022

Something is wrong with Docker registry:

Pulling clickhouse-server (clickhouse/clickhouse-server:22.5.1.2079)...
[11](https://github.com/xzkostyan/clickhouse-sqlalchemy/runs/8073182468?check_suite_focus=true#step:7:12)
Head "https://registry-1.docker.io/v2/clickhouse/clickhouse-server/manifests/22.5.1.2079": Get "https://auth.docker.io/token?account=githubactions&scope=repository%3Aclickhouse%2Fclickhouse-server%3Apull&service=registry.docker.io": EOF
[12](https://github.com/xzkostyan/clickhouse-sqlalchemy/runs/8073182468?check_suite_focus=true#step:7:13)
Error: Process completed with exit code 1.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 83.808% when pulling 91c830c on akolov:development-large-int-types into 7848994 on xzkostyan:master.

@xzkostyan xzkostyan merged commit b60c624 into xzkostyan:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for UInt128 (and others?)
3 participants