-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings final clause #292
Add settings final clause #292
Conversation
There is more convenient way to define settings with But this only is not supported for HTTP-driver. For HTTP-driver you must add SETTINGS in query. In Native settings are passed in special binary block. There will be conflict in native driver if this PR will be merged. ClickHouse server will get two section setting -- in binary form and in text form. There are two options:
I'd recommend to implement the second option. It will be more flexible. |
Thanks for your insight. Let me know if this is what you meant. |
Yes, that's it. |
Adding
SETTINGS final = 1
in the end of the query.This is a useful ClickHouse feature to apply FINAL to all tables in the query:
"Automatically applies FINAL modifier to all tables in a query, to tables where FINAL is applicable, including joined tables and tables in sub-queries, and distributed tables."
https://clickhouse.com/docs/en/operations/settings/settings#final
A known issue when having joined tables in query.
ClickHouse/ClickHouse#8655
Checklist:
flake8
and fix issues.pytest
no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.Tests fix:
fix(parsing): change the way to quote db_url to fix the test broken by sqlalchemy 2.0.25