fix raw connection execute #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. This looks fine. But, please add simple test to cover this case: class SomeTestCase(NativeSessionTestCase):
def test_example(self):
raw = self.session.bind.raw_connection()
cur = raw.cursor()
cur.execute("SELECT * FROM system.numbers LIMIT 10")
# assert smth |
|
Hi, I've added 2 tests (one with context, the other without) so both conditions in |
|
Hi Guys, sorry to bother you with this but any plans to tag a new release that include this fix ? |
|
@Matt-Texier no problem. I've just published 0.0.9 version with this fix. |
|
@xzkostyan many thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following my bug report #39 , here's a simple check on context during execute preparation.
It does fix the raw connection execution and make no changes when a context is set (vast majority of use cases) however it implies that no execution options can be passed when in raw mode.