Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, here is a join support for standard sqla-core (issue) and some kind of joins-api refactor.
Example is here:
tests.sql.test_schema.SchemaTestCase#test_reflect
.The magic is here:
clickhouse_sqlalchemy.drivers.base.ClickHouseDialect#reflecttable
.I replace table bounded with metadata by the table with another class.
The place that can make you sad is
clickhouse_sqlalchemy.orm.query.Query#join
. But I hope it is not: can't invent another way to make this possible: there are a lot of work inside ofsqlalchemy.orm.query.Query#join
method which should be done, but in the and another class must be used.