Add support for CODEC
column option
#89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the discussion from here, this implements the required changes to add support for the dialect-specific
CODEC(...)
column option. Thank you for the hints regarding the implementation, they proved helpful in getting this started!I got a little bit confused by your original message mentioning
visit_column
and realizing that this method only generates the column name, however looking around in the MSSQL implementation revealed that overridingget_column_specification
appears the be the way to go. I never thought that MSSQL would prove to be helpful for anything in my life, but I stand corrected.In the edited comment you changed it to
visit_create_column
, which I tested and can confirm that having the code in this method would also work. This PR currently implements theget_column_specification
approach, but I could just as well move the code down a few lines if you'd prefer that -- just say the word.Also, would you want to advertise this feature in the README?
Fixes #88