Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels using cibuildwheel #65

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Conversation

davidbrochart
Copy link
Contributor

No description provided.

@davidbrochart
Copy link
Contributor Author

@dmonad @Waidhoferj I heard you had issues building wheels with maturin, it seems to work fine with this PR (which uses cibuildwheel).

@SylvainCorlay
Copy link

@dmonad it would be great if this was merged. We have been blocked on this for a few weeks already!

@dmonad
Copy link
Contributor

dmonad commented Jan 18, 2022

If I understand correctly, this only builds y-py, correct? What does this action do actions/upload-artifact@v2?

The current build script releases a new y-py package on pypi using environment variables that I configured (I think it's my account). How does this script actually release the build?

@davidbrochart
Copy link
Contributor Author

If I understand correctly, this only builds y-py, correct?

Yes.

What does this action do actions/upload-artifact@v2?

It uploads the wheels as a zip file, that you can then download by clicking artifact at the bottom of this page: https://github.com/davidbrochart/y-crdt/actions/runs/1628614117

y_py-0.2.0-cp310-cp310-macosx_10_9_x86_64.whl
y_py-0.2.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
y_py-0.2.0-cp310-cp310-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
y_py-0.2.0-cp310-none-win_amd64.whl
y_py-0.2.0-cp37-cp37m-macosx_10_9_x86_64.whl
y_py-0.2.0-cp37-cp37m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
y_py-0.2.0-cp37-cp37m-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
y_py-0.2.0-cp37-none-win_amd64.whl
y_py-0.2.0-cp38-cp38-macosx_10_9_x86_64.whl
y_py-0.2.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
y_py-0.2.0-cp38-cp38-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
y_py-0.2.0-cp38-none-win_amd64.whl
y_py-0.2.0-cp39-cp39-macosx_10_9_x86_64.whl
y_py-0.2.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
y_py-0.2.0-cp39-cp39-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl
y_py-0.2.0-cp39-none-win_amd64.whl

The current build script releases a new y-py package on pypi using environment variables that I configured (I think it's my account). How does this script actually release the build?

This requires a PyPI upload token, stored in your GitHub repo's secrets as pypi_password (see https://cibuildwheel.readthedocs.io/en/stable/deliver-to-pypi/#github-actions).
Do you want me to include this step?

@davidbrochart
Copy link
Contributor Author

davidbrochart commented Jan 18, 2022

I just added the "Publish wheels to PyPI" step. It uses the same secrets that you have in main.yml (secrets.PYPI_USERNAME and secrets.PYPI_PASSWORD), and it is triggered when you push a tag.

@davidbrochart
Copy link
Contributor Author

I removed the PyPI publishing for now, I will try it out with a dummy PyPI project.

@davidbrochart
Copy link
Contributor Author

I just tested publishing on PyPI in this branch: https://github.com/davidbrochart/y-crdt/tree/test_pypi
It works, see the yy-py project: https://pypi.org/project/yy-py/0.2.2/#files
I installed it on my Linux machine with pip install yy-py and could import y_py successfully.
I'll push the changes here.

@davidbrochart
Copy link
Contributor Author

@dmonad OK to merge?

@Waidhoferj
Copy link
Contributor

I'm all for it 👍

@dmonad dmonad merged commit 8770d70 into y-crdt:main Jan 21, 2022
@davidbrochart davidbrochart deleted the cibuildwheel branch January 21, 2022 15:50
Horusiath pushed a commit to Horusiath/y-crdt that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants