Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 0.8.1 -> 0.8.2 #218

Merged
merged 6 commits into from Sep 27, 2018
Merged

[WIP] 0.8.1 -> 0.8.2 #218

merged 6 commits into from Sep 27, 2018

Conversation

ephread
Copy link
Collaborator

@ephread ephread commented Sep 8, 2018

It's still a work in progress. Two tests are failing.

The changes are not particularly nasty, so the merge can theoretically be done before cleaning up the typescript branch.

@ephread ephread mentioned this pull request Sep 8, 2018
@ephread ephread changed the title [Do Not Merge] [WIP] 0.8.1 -> 0.8.2 [WIP] 0.8.1 -> 0.8.2 Sep 10, 2018
@ephread
Copy link
Collaborator Author

ephread commented Sep 10, 2018

One the tests fails because of the changes made to LIST_RANGE. The test will need to be updated to match the new behavior.

The other issue seems to be a rehash of the whitespace issues we've encountered many times. I probably won't have the chance to look into it this week, so if anyone wants to take it from here, feel free to do so!

@ephread ephread changed the base branch from typescript to master September 24, 2018 02:03
Copy link
Owner

@y-lohse y-lohse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! That was quite pleasant to review because of typescript and matching orders.

Would ou be abble to add types and casting on minBound and maxBound? All other changes from 0.8.2 are there so we'd be good to go :)

edit: If you don't have time to add them, I'm happy to do it !

src/InkList.ts Show resolved Hide resolved
@ephread
Copy link
Collaborator Author

ephread commented Sep 27, 2018

Awesome, thanks! That was quite pleasant to review because of typescript and matching orders.

Happy to see that we're faster than ever!

@y-lohse y-lohse merged commit 03aa78d into y-lohse:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants