New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] 0.8.1 -> 0.8.2 #218
[WIP] 0.8.1 -> 0.8.2 #218
Conversation
One the tests fails because of the changes made to LIST_RANGE. The test will need to be updated to match the new behavior. The other issue seems to be a rehash of the whitespace issues we've encountered many times. I probably won't have the chance to look into it this week, so if anyone wants to take it from here, feel free to do so! |
37fb270
to
04bec09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! That was quite pleasant to review because of typescript and matching orders.
Would ou be abble to add types and casting on minBound
and maxBound
? All other changes from 0.8.2 are there so we'd be good to go :)
edit: If you don't have time to add them, I'm happy to do it !
Happy to see that we're faster than ever! |
It's still a work in progress. Two tests are failing.
The changes are not particularly nasty, so the merge can theoretically be done before cleaning up the
typescript
branch.