Fixes to external function evaluation

[joningold]

A couple of lines required to fix external function evaluation seem to have fallen out of the latest version. (However, you'd better check that they really did get missed by mistake rather than being taken out deliberately!) And apologies, but I don't have a decent test case -- if I run my local js ink project, I get the "expected" results with these fixes, but not without.

[erkyrath]

Speaking of external functions... Lectrote has no way to load externals, and it never will (for security reasons). But fallback functions don't work. The engine throws:

Missing function binding for external: 'extfunc' (ink fallbacks disabled) StoryException

Am I supposed to directly set story.allowExternalFunctionFallbacks = true? After creating the story instance, I mean.

[joningold]

Yes; I've always done it by hacking the ink.js file directly but you need to set that true. Jon

…

On Tue, 7 Mar 2017 at 5:40 pm, Andrew Plotkin ***@***.***> wrote: Speaking of external functions... Lectrote has no way to load externals, and it never will (for security reasons). But fallback functions don't work. The engine throws: Missing function binding for external: 'extfunc' (ink fallbacks disabled) StoryException Am I supposed to directly set story.allowExternalFunctionFallbacks = true? After creating the story instance, I mean. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#53 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA40o5S8CbWAL9chx7PYrwMrrnPxiwMJks5rjZaagaJpZM4MVTEp> .

[y-lohse]

Thank you! I've merged it into the dev branch, release to follow.