Core ink fix: callstack used for external function #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a function using "story.EvaluateFunction", the ink caches the old callstack and makes a new one until the function evalutation is complete. However, the VariablesState object holds a pointer to the callstack which it uses for creating temporary variables. This fix updates the VariablesState objects callstack when the function evaluation begins, and resets it once complete. (Matches main ink repo commit 7477026cf35ee06fa93eee194e01bf03fe94c9a8)
|
Thanks! |
|
Yeah, we fixed this the other day and I thought I'd do the PR so you had it
to hand. So merge at your leisure!
Cheers
Jon
…On Sat, 28 Jan 2017 at 10:26 pm, Yannick Lohse ***@***.***> wrote:
Thanks!
If I'm not mistaken, this change happened *after* ink 0.7.0 and is not
officially out yet, right? If so I'll wait to merge this PR until it's part
of a published ink version, or I'll end up being all confused :D
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#52 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA40o2oWMOR1n9O-sbZkICRYx4y3evUXks5rW8B_gaJpZM4Lq8th>
.
|
|
Looks like we merged that one in #53! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a function using "story.EvaluateFunction", the ink caches the old callstack and makes a new one until the function evalutation is complete. However, the VariablesState object holds a pointer to the callstack which it uses for creating temporary variables.
This fix updates the VariablesState objects callstack when the function evaluation begins, and resets it once complete.
(Matches main ink repo commit 7477026cf35ee06fa93eee194e01bf03fe94c9a8)