Bugfix: previous container list wasn't cleared #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The equivalent c# for this section is // First, find the previously open set of containers if( _prevContainerSet == null ) _prevContainerSet = new HashSet<Container> (); _prevContainerSet.Clear(); ...with the if'd statement being there to avoid multiple allocations, but the Clear() being called every time. The JS was missing this clear, resulting in previous containers hanging around.
|
Good catch, Thanks for taking the time to submit the bug, find the origin and send a patch 😃 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The equivalent c# for this section is
// First, find the previously open set of containers
if( _prevContainerSet == null ) _prevContainerSet = new HashSet ();
_prevContainerSet.Clear();
...with the if'd statement being there to avoid multiple allocations, but the Clear() being called every time. The JS was missing this clear, resulting in previous containers hanging around.