Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visit counts not incrementing correctly #54

Closed
joningold opened this issue Mar 7, 2017 · 4 comments
Closed

Visit counts not incrementing correctly #54

joningold opened this issue Mar 7, 2017 · 4 comments
Labels

Comments

@joningold
Copy link
Contributor

The following ink source generates different results in inky and in ink-js after web export.

-> game

=== game 
= main 
    -> top 
= top 
    COUNT = {top}
    + Loop -> main

In particular, the ink-js version does not increase the value of "top" as printed on the COUNT = line.

@joningold
Copy link
Contributor Author

Addendum: after a minor amount of digging, I suspect the Container "parent" property isn't being set correctly, as in the above example, going up the parent chain seems to get us from "main" to "top" via a Container with the path "".

@joningold
Copy link
Contributor Author

Found it! My latest pull request addresses the issue.

@y-lohse
Copy link
Owner

y-lohse commented Mar 8, 2017

I confirm #55 fixed it, thanks again!

@y-lohse y-lohse closed this as completed Mar 8, 2017
@y-lohse y-lohse added the bug label Mar 8, 2017
@joningold
Copy link
Contributor Author

joningold commented Mar 8, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants