New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation to calculate conditional independencies #29
Conversation
If this ever gets appended, then there's a big problem
this is a project requirement, so it's okay to assume it's installed.
@JosephCottam I think it's quite mature - can you please take care of all of the linting warnings then I will give a proper review? |
@cthoyt I have addressed most of the formatting issues. @cthoyt @djinnome I move that we ignore error N400 (backslash for line continuation). The PEP8 description centers on expressions with operator chaining. However, it is used for function chaining here. Though the warning can be cleared by adding parenthesis around the whole chain (see below), I think the line continuation version is more clear in what is going on.
|
@JosephCottam it looks like some of the tests started failing, but not related to code I changed. Are these non-deterministic, or is there something I missed? |
@cthoyt To the best of my knowledge, all of the tests are deterministic. |
@cthoyt Fixed the test case that started failing. The changes made to loading the asia example data broke that test case. It was just putting the file path into the dataframe, rather than loading the data from the file. Now it loads the data again! |
Remove hanging multi-line code
Nice catch, sorry for the trouble |
Thank you so much @JosephCottam for all of the effort! Looking forward to what's next |
Closes #24
This pull request implements an algorithm to calculate all conditional independencies in a given ADMG.