-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation to calculate conditional independencies #29
Merged
Merged
Changes from 94 commits
Commits
Show all changes
100 commits
Select commit
Hold shift + click to select a range
dd48578
Add outline of calculate conditional independencies
cthoyt 919c1d1
Merge branch 'main' into calculate-conditional-independencies
cthoyt 0ccf0df
Merge branch 'main' into calculate-conditional-independencies
cthoyt 0aa3a27
Merge branch 'main' into calculate-conditional-independencies
cthoyt 309ab7d
Potential path for falsification
JosephCottam 6037ebe
First draft that looks at given-variables. Needs work still.
JosephCottam f1cc89a
Able to test condtional independence with givens.
JosephCottam 5967c9e
Move falsification into a module, made some unit tests
JosephCottam 467798c
Using ADMG for falsification
JosephCottam fdcf0f7
Draw method added to mixed graph
JosephCottam 3826c83
Merge branch 'main' into calculate-conditional-independencies
cthoyt 9f1a019
Clean up tests
cthoyt 3330ae4
Remove redundant definition
cthoyt 8a4b209
Remove mutable default value
cthoyt 2bcc2ce
Use top-level import of tqdm
cthoyt 32e7bb2
Flake8 (mostly) compliance.
JosephCottam d86143a
Moved d-separation test graph to examples
JosephCottam 4f37aa3
Notes on next steps.
JosephCottam ac1b0d1
Add title to draw function
cthoyt 7c4bf9f
Automatically look up current axis
cthoyt 4baf384
Fix import order
cthoyt 3b42b34
Make classes for results reusable
cthoyt 43fc539
Rename module to follow pep8
cthoyt 6a9959a
Code style updates
cthoyt 5300849
More flake8 and style
cthoyt 1db9e86
Extract code for getting augments
cthoyt f9f2a61
Update falsification.py
cthoyt 44424d6
Simplify and document more code
cthoyt 5ebf0c6
Modified coloring to emphasize line (instead of column)
JosephCottam 6319448
Added more compact repr for conditional independencies
JosephCottam a962b03
Adding conditional independences for d-separation example graph, calc…
JosephCottam eae5061
*Draft* at conditional independencies generation (known to report too…
JosephCottam 921692d
More compact error messages for conditional independence test failures.
JosephCottam 6097379
Make matplotlib dependency more optional
cthoyt 8e1f106
Update docstring
cthoyt 0b4e7e0
Normalize repr
cthoyt 4cdee76
Fix kwarg
cthoyt 3b92f51
Removing todo (was done in an earlier commit)
JosephCottam 2ffef82
Added acencestor-style toplogocial restriction. Not sufficient to ge…
JosephCottam 9bcf2de
Reverting to domain-semantic name
JosephCottam 32682fd
Error messages that scale to the size of the extra info.
JosephCottam ee582dc
Added path restriction conditional independency.
JosephCottam eed5a36
Possible path outlined for fewer redundant CIs
JosephCottam ee1ed6b
Adding missed conditional independency
JosephCottam 8a87862
Removing minimization from ConditionalIndependency, moving to the ite…
JosephCottam 9a10b65
Ignoring multi-line statements
JosephCottam 4f6597f
flake8 compliance progress
JosephCottam 93ba53c
Conditional Independency test only checks the left/right members.
JosephCottam cc1b570
Correcting expected independencies as per causalfusion.
JosephCottam 307aca0
Test checks that conditional independency set is valid.
JosephCottam e7be0e8
Generalized policy argument so length of givens list doesn't have to …
JosephCottam 93f35d4
Renamed methods and added documentation
JosephCottam c404145
Falsification example working! (again)
JosephCottam 310276c
Adding Holm–Bonferroni multiple-comparisons correction to falsification
JosephCottam 08eb955
Removed references to dsl.Variable from ConditionalIndependency and F…
JosephCottam fc2d652
Merged DSeparation and ConditionalIndependency
JosephCottam cbe7cd2
Removed DSeparationJudgement context object due to dubious utility
JosephCottam 227892c
Formatting for flake8
JosephCottam 1156b24
Documentation notes
JosephCottam 14b2b87
Update identifiability 2 example
cthoyt e97613e
Pass mypy
cthoyt da1433c
Update names in tests
cthoyt fa9101f
Remove unnecessary changes in flake8
cthoyt a978bd1
More code reorganization for clarity and readability
cthoyt 95441cd
Update .flake8
cthoyt a827c77
Update type checking of graphs
cthoyt a332a06
Reorganize tests
cthoyt 0ca1707
Fixed example 2 graph.
JosephCottam 66e43af
Added topological policy
JosephCottam 5ec3c5a
Testing that all the references samples are covered (still need to ch…
JosephCottam b53555d
Moved powerset utility to the utils package
JosephCottam 2f80c9e
Testing that found conditional independencies are at least as good as…
JosephCottam 8583e56
Testing additional d-separations
JosephCottam 7ba7ea8
Removing extra conditions on d-separations
JosephCottam 67f63f0
Documentation
JosephCottam 23481de
Only returns FIRST left/right/conditions set from the d-separation it…
JosephCottam a805f3d
Documentation clarification and tests for moral_links step of d-separ…
JosephCottam 96a4d71
Falsification updated for ConditionalIndependence/DSeparationJudgemen…
JosephCottam f9e4c48
Documentation & test cases
JosephCottam 9a5eefd
Reparameterized to reflect opitional arguments better.
JosephCottam f84736f
Testing alternative interface
JosephCottam b69b217
Documentation for utilities
JosephCottam dccf552
Fixing (some) flake8 issues
JosephCottam 44ae458
Flake8 formatting compliance.
JosephCottam 967becb
More flake8 formatting compliance.
JosephCottam add8226
More flake8 formatting compliance.
JosephCottam c4b8397
Fix usage of backslashes
cthoyt 2a2a5db
Update falsification.py
cthoyt a85262b
Make it possible to use custom policy
cthoyt bb6e91a
Fix typos
cthoyt 8088b39
Simplify code
cthoyt 45ac906
Text updates
cthoyt f57b33a
Make pipe action its own function
cthoyt 39b5afd
More simple data loading
cthoyt 4fb5311
Fixing falsification tests by propertly loading example data
JosephCottam 5e2e491
Generalizing parameters
JosephCottam a96520c
Ignoring jupyter temporaries and simplified report format
JosephCottam fa39951
More flake8 formatting compliance.
JosephCottam 154e43d
Add type annotation
cthoyt ec5adf8
Update code style in tests
cthoyt File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the terminal, the character number was much more visible than the line-number. This change made the line-number more emphasized.
These days I'm actually using
format = ${red}%(code)s${reset} ${cyan}%(path)s${reset}:${red_bold}%(row)d${reset} %(text)s
. Which doesn't give the character number at all and moves the error-code to the left (where it is easier to ignore because its rarely needed).