Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.propOrbits[ia] is undefined with sync siteswap (4,0) #4

Closed
topox opened this issue Dec 7, 2015 · 2 comments
Closed

x.propOrbits[ia] is undefined with sync siteswap (4,0) #4

topox opened this issue Dec 7, 2015 · 2 comments

Comments

@topox
Copy link

topox commented Dec 7, 2015

Hello yDgunz!

With the sync siteswap (4,0) I get the error "x.propOrbits[ia] is undefined" and it won't be juggled. But it is a valid synchronous siteswap. Please fix. Thanks!

@yDgunz
Copy link
Owner

yDgunz commented Dec 7, 2015

Well I'm surprised I never tested this with one of the simplest siteswaps! The bug appears to be in the section of code that figures out where the hand is supposed to go when it doesn't have a prop in it. The hand is supposed to start moving to the position where it will next catch a prop, but in the case of (4,0) there is no prop to catch. I think the correct thing to do will be to have the hand just stay at dwell position (0,0,0) - basically straight ahead.

Thanks for the heads up, I'll probably fix this in the next release.

yDgunz added a commit that referenced this issue Dec 18, 2015
… incorporate into other areas. Fixing #4 by having the empty hand in 1 handed siteswaps like (4,0) in a static position. Fixing sync siteswap dwell path issues in #5 by not incrementing dwell path index on 0 tosses. Also fixing some scroll issues in the controls
@yDgunz
Copy link
Owner

yDgunz commented Aug 8, 2016

Fixed this in v17.

@yDgunz yDgunz closed this as completed Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants