Fix #224 and #857 - toolbar in absolute container

[linkesch]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
New tests added?	not needed
Fixed tickets	#224, #857
License	MIT

Description

Fix positioning of a toolbar and an anchor preview when elementsContainer has position: absolute or position: fixed.

If elementsContainer is absolute or fixed, it will calculate positions relative to this element instead of window.

I also added a demo demo/absolute-container.html which demonstrates this behavior.

[coveralls]

Coverage decreased (-0.7%) to 94.184% when pulling a5ea3df on fix-toolbar-in-absolute-container into d57e4b2 on master.

[nmielnik]

Could the calculation of the adjustment of top be done within the if(elementsContainerAboslute) block above?

Something like:

var topAdjustment = this.window.pageYOffset;

 // If container element is absolute / fixed, recalculate boundaries to be relative to the container
 if (elementsContainerAbsolute) {
    // other existing logic...

    topAdjustment = elementsContainer.scrollTop;
}

middleBoundary = boundary.left + boundary.width / 2;
positions.top = (boundary.top - toolbarHeight) + topAdjustment;

That way we can have one less if-condition.

[linkesch]

Good point. I'll do that

[coveralls]

Coverage decreased (-0.3%) to 94.652% when pulling 72055ea on fix-toolbar-in-absolute-container into d57e4b2 on master.

[coveralls]

Coverage increased (+0.05%) to 94.974% when pulling 97223ab on fix-toolbar-in-absolute-container into d57e4b2 on master.