Update jsDelivr links #1366
Merged
Update jsDelivr links #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 96fae38 on LukasDrgon:patch-1 into ** on yabwe:master**. |
This was referenced Sep 5, 2017
Merged
Merged
rishijain
reviewed
Sep 5, 2017
| @@ -51,8 +51,8 @@ Run in your console: `npm install medium-editor` | |||
| For a custom one: | |||
|
|
|||
| ```html | |||
| <script src="//cdn.jsdelivr.net/medium-editor/4.11.1/js/medium-editor.min.js"></script> | |||
| <link rel="stylesheet" href="//cdn.jsdelivr.net/medium-editor/4.11.1/css/medium-editor.min.css" type="text/css" media="screen" charset="utf-8"> | |||
| <script src="//cdn.jsdelivr.net/npm/medium-editor@5.23.2/dist/js/medium-editor.min.js"></script> | |||
There was a problem hiding this comment.
@LukasDrgon why not we change the src to use this src="//cdn.jsdelivr.net/npm/medium-editor@latest/dist/js/medium-editor.min.js" ?
There was a problem hiding this comment.
@rishijain if you check the full readme, you have two versions of the links there. One with latest and one with a specific version.
There was a problem hiding this comment.
ah my bad. completely missed it. Thanks for the change.
There was a problem hiding this comment.
@MartinKolarik @LukasDrgon maybe you can change the path to the latest version to use the new system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsDelivr switched to a fully automated system, that can serve files from npm and GitHub. This means all future releases will be available automatically, but will use a new link structure.
I updated the links now so you don't forget to do it when you release a new version.
I also changed the version to the latest one.
You can find links for all files at https://www.jsdelivr.com/package/npm/medium-editor.
Feel free to ping me if you have any questions regarding this change.