Bug fix for #1369 #1370
Merged
Bug fix for #1369 #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 301d05f on ndjamenamarmon:1369 into ** on yabwe:master**. |
rishijain
approved these changes
Sep 13, 2017
|
Hi @ndjamenamarmon , Thank you for the fix. Can you please squash your commits into a single commit ? |
jamenamcinteer
force-pushed
the
1369
branch
from
301d05f
to
0e809bb
Compare
|
Hi Rishi, I have squashed the commits now. Please let me know if there are any further issues. |
|
👍 ⭐️ |
|
Changes Unknown when pulling 0e809bb on ndjamenamarmon:1369 into ** on yabwe:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Firefox console warning when there are multiple medium editor textareas: "Use of attributes' nodeValue attribute is deprecated. Use value instead." This is coming from line 6929 in dist/js/medium-editor.js. By changing atts[i].nodeValue to atts[i].value the warning goes away as well as the bug this caused in the application where medium editor was being used (Firefox only).