Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix simple typo, begining -> beginning #1538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: Fix simple typo, begining -> beginning #1538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions dist/js/medium-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2298,7 +2298,7 @@ MediumEditor.extensions = {};
*
* @param {DOMElement} An element containing the cursor to find offsets relative to.
* @param {Range} A Range representing cursor position. Will window.getSelection if none is passed.
* @return {Object} 'left' and 'right' attributes contain offsets from begining and end of Element
* @return {Object} 'left' and 'right' attributes contain offsets from beginning and end of Element
*/
getCaretOffsets: function getCaretOffsets(element, range) {
var preCaretRange, postCaretRange;
Expand Down Expand Up @@ -6627,13 +6627,13 @@ MediumEditor.extensions = {};
// at the very end of the block
MediumEditor.selection.getCaretOffsets(node).left === 0) {
if (MediumEditor.util.isKey(event, MediumEditor.util.keyCode.BACKSPACE) && isEmpty.test(node.previousElementSibling.innerHTML)) {
// backspacing the begining of a header into an empty previous element will
// backspacing the beginning of a header into an empty previous element will
// change the tagName of the current node to prevent one
// instead delete previous node and cancel the event.
node.previousElementSibling.parentNode.removeChild(node.previousElementSibling);
event.preventDefault();
} else if (!this.options.disableDoubleReturn && MediumEditor.util.isKey(event, MediumEditor.util.keyCode.ENTER)) {
// hitting return in the begining of a header will create empty header elements before the current one
// hitting return in the beginning of a header will create empty header elements before the current one
// instead, make "<p><br></p>" element, which are what happens if you hit return in an empty paragraph
p = this.options.ownerDocument.createElement('p');
p.innerHTML = '<br>';
Expand All @@ -6653,7 +6653,7 @@ MediumEditor.extensions = {};
// hitting delete in an empty element preceding a header, ex:
// <p>[CURSOR]</p><h1>Header</h1>
// Will cause the h1 to become a paragraph.
// Instead, delete the paragraph node and move the cursor to the begining of the h1
// Instead, delete the paragraph node and move the cursor to the beginning of the h1

// remove node and move cursor to start of header
MediumEditor.selection.moveCursor(this.options.ownerDocument, node.nextElementSibling);
Expand Down Expand Up @@ -6696,7 +6696,7 @@ MediumEditor.extensions = {};
(MediumEditor.util.getClosestTag(node, 'blockquote') !== false) &&
MediumEditor.selection.getCaretOffsets(node).left === 0) {

// when cursor is at the begining of the element and the element is <blockquote>
// when cursor is at the beginning of the element and the element is <blockquote>
// then pressing backspace key should change the <blockquote> to a <p> tag
event.preventDefault();
MediumEditor.util.execFormatBlock(this.options.ownerDocument, 'p');
Expand Down
6 changes: 3 additions & 3 deletions spec/header-tags.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('Protect Header Tags TestCase', function () {

describe('ProtectHeaderTags', function () {
it('header intact after leading return', function () {
// place cursor at begining of header
// place cursor at beginning of header
var editor = this.newMediumEditor('.editor'),
el = document.getElementById('header'),
range = document.createRange(),
Expand All @@ -37,7 +37,7 @@ describe('Protect Header Tags TestCase', function () {
});

it('header leading return inserts paragraph, not additional header', function () {
// place cursor at begining of header
// place cursor at beginning of header
var editor = this.newMediumEditor('.editor'),
el = document.getElementById('header'),
range = document.createRange(),
Expand All @@ -58,7 +58,7 @@ describe('Protect Header Tags TestCase', function () {
});

it('header leading backspace into empty p preserves header', function () {
// place cursor at begining of header
// place cursor at beginning of header
var editor = this.newMediumEditor('.editor'),
originalHTML = document.getElementById('editor').innerHTML,
el = document.getElementById('header'),
Expand Down
8 changes: 4 additions & 4 deletions src/js/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,13 @@
// at the very end of the block
MediumEditor.selection.getCaretOffsets(node).left === 0) {
if (MediumEditor.util.isKey(event, MediumEditor.util.keyCode.BACKSPACE) && isEmpty.test(node.previousElementSibling.innerHTML)) {
// backspacing the begining of a header into an empty previous element will
// backspacing the beginning of a header into an empty previous element will
// change the tagName of the current node to prevent one
// instead delete previous node and cancel the event.
node.previousElementSibling.parentNode.removeChild(node.previousElementSibling);
event.preventDefault();
} else if (!this.options.disableDoubleReturn && MediumEditor.util.isKey(event, MediumEditor.util.keyCode.ENTER)) {
// hitting return in the begining of a header will create empty header elements before the current one
// hitting return in the beginning of a header will create empty header elements before the current one
// instead, make "<p><br></p>" element, which are what happens if you hit return in an empty paragraph
p = this.options.ownerDocument.createElement('p');
p.innerHTML = '<br>';
Expand All @@ -91,7 +91,7 @@
// hitting delete in an empty element preceding a header, ex:
// <p>[CURSOR]</p><h1>Header</h1>
// Will cause the h1 to become a paragraph.
// Instead, delete the paragraph node and move the cursor to the begining of the h1
// Instead, delete the paragraph node and move the cursor to the beginning of the h1

// remove node and move cursor to start of header
MediumEditor.selection.moveCursor(this.options.ownerDocument, node.nextElementSibling);
Expand Down Expand Up @@ -134,7 +134,7 @@
(MediumEditor.util.getClosestTag(node, 'blockquote') !== false) &&
MediumEditor.selection.getCaretOffsets(node).left === 0) {

// when cursor is at the begining of the element and the element is <blockquote>
// when cursor is at the beginning of the element and the element is <blockquote>
// then pressing backspace key should change the <blockquote> to a <p> tag
event.preventDefault();
MediumEditor.util.execFormatBlock(this.options.ownerDocument, 'p');
Expand Down
2 changes: 1 addition & 1 deletion src/js/selection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@
*
* @param {DOMElement} An element containing the cursor to find offsets relative to.
* @param {Range} A Range representing cursor position. Will window.getSelection if none is passed.
* @return {Object} 'left' and 'right' attributes contain offsets from begining and end of Element
* @return {Object} 'left' and 'right' attributes contain offsets from beginning and end of Element
*/
getCaretOffsets: function getCaretOffsets(element, range) {
var preCaretRange, postCaretRange;
Expand Down