Fix Problem with text selection ending outside the container div #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is the best solution. What happens when we have multiple instances of the Editor? Also, we need to unbind it when we deactivate the editor. |
|
I don't thing that actually Medium-Editor is working correctly with multiple editor with the same classname. |
devalnor
added a commit
to devalnor/medium-editor
that referenced
this pull request
Nov 18, 2013
- Improve getSelectionElement() to work in any cases and fixed the bug on multi element selection. - Fix Issue yabwe#88 & yabwe#89 - Refactor the fix for yabwe#86 (sorry for that but I don’t understand why to bind mousedown is required. This execute checkSelection() twice. So I tried to merge both code for a better and clean code. Hope it’s ok) - Improved binding for multiple editor instance. checkSelection() is called only one time per instance. - Improved allowMultiParagraphSelection filter by removing empty tags elements before counting and consider header tags has a paragraph too (same as medium).
nysk
pushed a commit
to nysk/medium-editor
that referenced
this pull request
Aug 10, 2015
- Improve getSelectionElement() to work in any cases and fixed the bug on multi element selection. - Fix Issue yabwe#88 & yabwe#89 - Refactor the fix for yabwe#86 (sorry for that but I don’t understand why to bind mousedown is required. This execute checkSelection() twice. So I tried to merge both code for a better and clean code. Hope it’s ok) - Improved binding for multiple editor instance. checkSelection() is called only one time per instance. - Improved allowMultiParagraphSelection filter by removing empty tags elements before counting and consider header tags has a paragraph too (same as medium).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#88