Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with text selection ending outside the container div #88

Closed
dmitrippp opened this issue Nov 17, 2013 · 0 comments
Closed

Problem with text selection ending outside the container div #88

dmitrippp opened this issue Nov 17, 2013 · 0 comments

Comments

@dmitrippp
Copy link

First of, thank you for creating this. There is a small problem with the text selection. In medium when you start a selection and end it with the mouse outside of the editable container div, the toolbar appears - this is user friendly. But in this plugin, when you start a selection and end it outside the container div, the toolbar does not appear.
devalnor added a commit to devalnor/medium-editor that referenced this issue Nov 18, 2013
@devalnor
Fix Problem with text selection ending outside the container div
d9ad50d 
yabwe#88
@devalnor devalnor mentioned this issue Nov 18, 2013
Closed
devalnor added a commit to devalnor/medium-editor that referenced this issue Nov 18, 2013
@devalnor
Enable Multi Editor in same or many instances.
1d327b7 
- Improve getSelectionElement() to work in any cases and fixed the bug on multi element selection.
- Fix Issue yabwe#88 & yabwe#89
- Refactor the fix for yabwe#86 (sorry for that but I don’t understand why to bind mousedown is required. This execute checkSelection() twice. So I tried to merge both code for a better and clean code. Hope it’s ok)
- Improved binding for multiple editor instance. checkSelection() is called only one time per instance.
- Improved allowMultiParagraphSelection filter by removing empty tags elements before counting and consider header tags has a paragraph too (same as medium).
@devalnor devalnor mentioned this issue Nov 18, 2013
Merged
nysk pushed a commit to nysk/medium-editor that referenced this issue Aug 10, 2015
@devalnor
Fix Problem with text selection ending outside the container div
483040b 
yabwe#88
nysk pushed a commit to nysk/medium-editor that referenced this issue Aug 10, 2015
@devalnor
Enable Multi Editor in same or many instances.
dde4f60 
- Improve getSelectionElement() to work in any cases and fixed the bug on multi element selection.
- Fix Issue yabwe#88 & yabwe#89
- Refactor the fix for yabwe#86 (sorry for that but I don’t understand why to bind mousedown is required. This execute checkSelection() twice. So I tried to merge both code for a better and clean code. Hope it’s ok)
- Improved binding for multiple editor instance. checkSelection() is called only one time per instance.
- Improved allowMultiParagraphSelection filter by removing empty tags elements before counting and consider header tags has a paragraph too (same as medium).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daviferreira @dmitrippp