Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLTextTool landscape keyboard #196

Closed
cliffjoyce opened this issue Oct 20, 2017 · 1 comment
Closed

CLTextTool landscape keyboard #196

cliffjoyce opened this issue Oct 20, 2017 · 1 comment

Comments

@cliffjoyce
Copy link

cliffjoyce commented Oct 20, 2017 •
edited

Using the 2017-10-18 build, the CLTextTool does not properly handle the keyboard in landscape orientations (the portrait keyboard always appears instead of the landscape keyboard).

To reproduce the issue: build the CLImageEditorDemo with Xcode 9 and launch the iPad Simulator in landscape orientation; tap the Edit button; tap the Text tool; tap the New button.

I think the issue is line 618 of _CLImageEditorViewController, because if I change line 618 to unconditionally return UIInterfaceOrientationMaskAll, then the landscape keyboard appears as expected.

A related issue: there's a UITextField that appears on screen while text is being typed. In the attached screenshot, you can see its blue insertion point just above the New button.

texttool-orientation-issue
@yackle yackle closed this as completed in 238898f Nov 29, 2017
@yackle
Copy link
Owner

yackle commented Nov 29, 2017

Thanks for reporting!

sahara108 added a commit to sahara108/CLImageEditor that referenced this issue Dec 26, 2017
@sahara108
Merge branch 'master' of https://github.com/yackle/CLImageEditor
d910c97 
* 'master' of https://github.com/yackle/CLImageEditor:
  Update podspec
  fix yackle#196
  yackle#186 set status bar hidden
  fix yackle#197
  yackle#201 Added default alphabetical sorting to custom stickers
  Fix yackle#195
  Update podspec
  Fix yackle#193
  Adjust tone curve tool menu for iPhone X
  Adjust for iPhone X
  Use auto layout
  Add launch image
  Doesn't consider CIImage backed image
stansmida added a commit to percolate/CLImageEditor that referenced this issue Nov 5, 2019
@stansmida
Merge branch 'master' of https://github.com/yackle/CLImageEditor into…
f707cb8 
… sync-upstream

* 'master' of https://github.com/yackle/CLImageEditor: (45 commits)
  Update podspec
  Use safeAreaLayoutGuide
  Add shared scheme
  Add project for Carthage
  Update podspec
  Fix warnings about implicity retaining self in block.
  yackle#206 Corrected sticker icon thumbnails content mode.
  Update podspec
  fix yackle#196
  yackle#186 set status bar hidden
  fix yackle#197
  yackle#201 Added default alphabetical sorting to custom stickers
  Fix yackle#195
  Update podspec
  Fix yackle#193
  Adjust tone curve tool menu for iPhone X
  Adjust for iPhone X
  Use auto layout
  Add launch image
  Doesn't consider CIImage backed image
  ...

# Conflicts:
#	CLImageEditor/CLImageEditor.bundle/Resources/en.lproj/Localizable.strings
#	CLImageEditor/CLImageEditorTheme.m
#	CLImageEditor/ImageTools/ToolSettings/CLToolbarMenuItem.m
#	CLImageEditor/ViewController/_CLImageEditorViewController.m
#	Demo/CLImageEditorDemo/CLImageEditorDemo/ViewController.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cliffjoyce @yackle