* tailing stdout needs bytestrings

see https://stackoverflow.com/questions/2715847/python-read-streaming-input-from-subprocess-communicate/17698359#17698359
yadage · Aug 1, 2017 · 6e48ad7 · 6e48ad7
1 parent 0db273e
commit 6e48ad7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packtivity/handlers/environment_handlers.py b/packtivity/handlers/environment_handlers.py
@@ -173,7 +173,7 @@ def docker_pull(docker_pull_cmd,log,state,metadata):
         time.sleep(0.5)
         log.debug('process children: %s',[x for x in psutil.Process(proc.pid).children(recursive = True)])
 
-        for line in iter(proc.stdout.readline, ''):
+        for line in iter(proc.stdout.readline, b''):
             pulllog.info(line.strip())
         while proc.poll() is None:
             pass
@@ -206,7 +206,7 @@ def docker_run_cmd(fullest_command,log,state,metadata):
         time.sleep(0.5)
         log.debug('process children: %s',[x for x in psutil.Process(proc.pid).children(recursive = True)])
 
-        for line in iter(proc.stdout.readline, ''):
+        for line in iter(proc.stdout.readline, b''):
             runlog.info(line.strip())
         while proc.poll() is None:
             pass