Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add six requirement to install requirements #36

Merged
merged 1 commit into from
Dec 14, 2021
Merged

build: Add six requirement to install requirements #36

merged 1 commit into from
Dec 14, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Oct 25, 2021

Resolves #35

The six.moves module

import six.moves.urllib as urllib

was added in six v1.4.0, setting the lower bound of six>=1.4.0.

The six.moves module was added in six v1.4.0, setting the lower bound of
six>=1.4.0
@matthewfeickert
Copy link
Member Author

@lukasheinrich This is ready for review.

@matthewfeickert
Copy link
Member Author

@lukasheinrich gentle ping on this.

@matthewfeickert
Copy link
Member Author

matthewfeickert commented Nov 24, 2021

@lukasheinrich If you can review this, and once merged release a new patch version v0.10.7 of yadage-schemas to PyPI, that would help things downstream for recast-atlas (c.f. recast-hep/recast-atlas#76).

@matthewfeickert
Copy link
Member Author

matthewfeickert commented Dec 6, 2021

@lukasheinrich As I'm not a member of the yadage GitHub organization, and so don't have commit rights, can you merge this PR now that it has been approved?

After this is merged if you can also create a v0.10.7 patch release of yadage-schemas and put it up on PyPI that would address the last bits of Issue #35.

@lukasheinrich lukasheinrich merged commit f053a5c into yadage:master Dec 14, 2021
@matthewfeickert matthewfeickert deleted the fix/specify-six-requirement branch December 14, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify six dependency
2 participants