Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toasts customisable #6

Closed
2 of 4 tasks
UshalNaidoo opened this issue Aug 9, 2016 · 2 comments
Closed
2 of 4 tasks

Make toasts customisable #6

UshalNaidoo opened this issue Aug 9, 2016 · 2 comments

Comments

@UshalNaidoo
Copy link

UshalNaidoo commented Aug 9, 2016

After looking through the code it seems like the toasts are quite hard coded, apart from the text it displays and the duration (which matches the normal toast duration of long (1) and short (0)).

Here are some suggestions so that others can begin to use this feature in their apps:

  • A default TastyToast.show(text) call that shows a default toast.
  • Change the background color TastyToast.show(text, #color)
  • Pass in the duration in milliseconds, with a maximum bound
  • Either pass in an image or an array of images to display the icon or a gif: TastyToast.show(text, #color, #image), TastyToast.show(text, #color, #image[])

Just a few suggestions.

@UshalNaidoo UshalNaidoo changed the title Don't always show animation on the Toast Make toasts customisable Aug 10, 2016
@yadav-rahul
Copy link
Owner

yadav-rahul commented Aug 10, 2016

@UshalNaidoo If u want to do this part then you can do that.

Rahul Yadav

On Wed, Aug 10, 2016 at 4:52 AM, Ushal Naidoo notifications@github.com
wrote:

There should be a flag to determine whether to show the animation or just
the end image.
Could I take up this task if you think it;s okay to do?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6, or mute the thread
https://github.com/notifications/unsubscribe-auth/AOdJdHi0CB2OhacaNnCxqf3WdIhpvySQks5qeQuggaJpZM4JgntY
.

@UshalNaidoo
Copy link
Author

I've created pull requests for 2 of those tasks, can you take a look at them, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants