Update version

yadickson · Jan 28, 2019 · ef456cf · ef456cf
1 parent bb3e444
commit ef456cf
Show file tree

Hide file tree

Showing 3 changed files with 80 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angularjs-atmosphere",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Angular JS atmosphere wrapper",
   "main": "dist/angularjs-atmosphere.js",
   "dependencies": {

diff --git a/src/angularjs-atmosphere.js b/src/angularjs-atmosphere.js
@@ -18,7 +18,8 @@
         close: close,
         on: on,
         off: off,
-        emit: emit
+        emit: emit,
+        request: request
       };
 
       function init(requestObj) {
@@ -53,8 +54,8 @@
       }
 
       function off(id) {
-        var type = listenerIndex[id];
-        var typeListeners = listeners[type];
+        var type = listenerIndex[id] || '';
+        var typeListeners = listeners[type] || [];
         var removed = false;
 
         for (var i = 0; i < typeListeners.length; i++) {
@@ -91,6 +92,10 @@
         }
       }
 
+      function request() {
+        return $.atmosphere.AtmosphereRequest();
+      }
+
     }]);
 
 })();
diff --git a/test/angularjs-atmosphere-test.js b/test/angularjs-atmosphere-test.js
@@ -44,6 +44,54 @@
       expect(fn.called).to.be.false;
     });
 
+    it('it should remove a function from the listeners object given an id with two registers', function() {
+      var fn = sinon.spy();
+      var fn2 = sinon.spy();
+
+      var key = atmosphereService.on('test', fn);
+      var key2 = atmosphereService.on('test2', fn2);
+
+      atmosphereService.off(key2);
+
+      atmosphereService.emit('test', 'test');
+      atmosphereService.emit('test2', 'test');
+
+      expect(!!key).to.be.true;
+      expect(fn.called).to.be.true;
+
+      expect(!!key2).to.be.true;
+      expect(fn2.called).to.be.false;
+    });
+
+    it('it emit json object a function from the listeners object given an id with two registers', function() {
+      var fn = sinon.spy();
+      var fn2 = sinon.spy();
+
+      var key = atmosphereService.on('test', fn);
+      var key2 = atmosphereService.on('test2', fn2);
+
+      atmosphereService.emit('test', angular.toJson('{"m":"test1"}'));
+      atmosphereService.emit('test2', angular.toJson('{"m":"test2"}'));
+
+      expect(!!key).to.be.true;
+      expect(fn.called).to.be.true;
+
+      expect(!!key2).to.be.true;
+      expect(fn2.called).to.be.true;
+    });
+
+    it('it remove a function is not present in the listeners object', function() {
+      var fn = sinon.spy();
+      var fn2 = sinon.spy();
+
+      var key = atmosphereService.on('test', fn);
+      var key2 = atmosphereService.on('test2', fn2);
+
+      var removed = atmosphereService.off(-1);
+
+      expect(removed).to.be.false;
+    });
+
     it('should call all the functions for a given event on a response', function() {
       var fn = sinon.spy();
       var fn2 = sinon.spy();
@@ -60,6 +108,29 @@
       expect(fn2.called).to.be.true;
     });
 
+    it('should call all the functions for a different event on a response', function() {
+      var fn = sinon.spy();
+      var fn2 = sinon.spy();
+
+      var key = atmosphereService.on('test', fn);
+      var key2 = atmosphereService.on('test2', fn2);
+
+      atmosphereService.emit('test', 'test');
+
+      expect(!!key).to.be.true;
+      expect(!!key2).to.be.true;
+
+      expect(fn.called).to.be.true;
+      expect(fn2.called).to.be.false;
+    });
+
+    it('call default request', function() {
+
+      var request = atmosphereService.request();
+
+      expect(!!request).to.be.true;
+    });
+
   });
 
 })();