Support multiple JpaDataStore
#2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklish
requested changes
May 30, 2023
| @@ -151,6 +171,7 @@ public Object loadObject(EntityProjection projection, Serializable id, RequestSc | |||
|
|
|||
| synchronized (dataStore) { | |||
| Map<String, Object> data = dataStore.get(projection.getType()); | |||
| cacheForRollback(projection.getType(), data); | |||
There was a problem hiding this comment.
I think we can remove the synchronized blocks in this class now that there is a read/write lock on the transaction
There was a problem hiding this comment.
Have removed the synchronized blocks.
| * @param target the bean to copy to | ||
| * @param cls the class | ||
| */ | ||
| public static void copyProperties(Object source, Object target, Type<?> cls) { |
There was a problem hiding this comment.
Nice improvements over the clone in MultiplexWriteTransaction.
aklish
approved these changes
Jun 3, 2023
|
I think the build error is transient. I tried running the failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support multiple transactional
JpaDataStorein Spring theMultiplexManagerneeded to be modified to process transactions last-in-first-out instead of first-in-first-out. After making this modification, a test was failing. The test was testing that the previously committed transaction on aHashMapDataStorewas being reversed by theMultiplexManager. Reversing the order meant that the transaction on theHashMapDataStorewasn't even being commited, however the data was still modified. The objects retrieved from theHashMapDataStoreare the same reference from the store, so any modifications to the store actually already modifies the data in the underlying store.In order to fix this the following things were done to the
HashMapDataStore.ReadWriteLockwas introduced so write transactions need an exclusive lock when making modificationsMultiplexManagerdoes to reverse the transactionThe new
HashMapDataStoreTest#testShouldNotReadDirtyDatatest demonstrates the issue and the fix.Description
JtaTransactionManageris now supported@EnableJpaDataStoreannotation is added to make it easy to add and configure multipleJpaDataStore. Allows configuring the entity manager, transaction manager or the managed classes.DataStoreBuilderCustomizerandJpaDataStoreRegistrationsBuilderCustomizerto allow customization of the autoconfiguration without needed to totally copy and paste the existing codes.MultiplexManagernow processes transactions last-in-first-out.HashMapDataStoremodified for data consistency.Motivation and Context
Makes it possible to have multiple transactional
JpaDataStorein the same transaction. Makes the configuration ofJpaDataStoreeasier.How Has This Been Tested?
Tested with unit and integration tests.
In particular the following were tested for Spring
JpaTransactionManagerand 2 xEntityManagerFactoryJtaTransactionManagerand 2 xEntityManagerFactoryThe Atomikos
JtaTransactionManagerwas used for the test.License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.