Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the request phase durations stored by RequestLog: replaces Pr/100 #159

Closed
wants to merge 1 commit into from
Closed

Expose the request phase durations stored by RequestLog: replaces Pr/100 #159

wants to merge 1 commit into from

Conversation

michael-mclawhorn
Copy link
Contributor

  • Add FiliTimingFilter to allow applications to use custom logging filters while retaining the non-logging related behaviors of the BardLoggingFilter
  • Refactored the RequestLog by spinning the model out into a seperate class and marking the existing class as a utility

New methods

  • RequestLogUtils.startTimingRequest
  • RequestLogUtils.stopTimingRequest

@michael-mclawhorn
Copy link
Contributor Author

Absorbed from: #100

@archolewa
Copy link
Contributor

👍

@michael-mclawhorn
Copy link
Contributor Author

👍 I still want @cdeszaq 's eyes on this, though.

michael-mclawhorn
michael-mclawhorn commented Feb 8, 2017
View reviewed changes
Copy link
Contributor Author

@michael-mclawhorn michael-mclawhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Rick identified what he thinks is a serious issue on this PR. Consider it blocked until he can circle around to address it in detail.

@archolewa
Expose the request phase durations stored by RequestLog
c9ce8af 
* Add FiliTimingFilter to allow applications to use custom logging filters while retaining the non-logging
  related behaviors of the BardLoggingFilter
* Refactored the RequestLog by spinning the model out into a seperate class and marking the existing class
  as a utility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archolewa archolewa archolewa approved these changes

@cdeszaq cdeszaq Awaiting requested review from cdeszaq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-mclawhorn @archolewa