Adds a timer around DataApiRequestMappers. #250
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- DataApiRequestMappers are allowed to perform arbitrary transformations on the `DataApiRequest`. As a result, these mappers may be very expensive. So, we should add a timer that allows customers to easily see if they are spending all their time in their own mappers.
cdeszaq
approved these changes
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- DataApiRequestMappers are allowed to perform arbitrary
transformations on the
DataApiRequest. As a result, these mappers maybe very expensive. So, we should add a timer that allows customers to
easily see if they are spending all their time in their own mappers.