Add ability to sort mixed-type lists to JsonSlurper #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archolewa
requested changes
Oct 6, 2016
| @@ -66,6 +66,8 @@ Current | |||
|
|
|||
| - [#45, removing sorting from weight check queries](https://github.com/yahoo/fili/pull/46) | |||
|
|
|||
| - `JsonSlurper` can now handle sorting lists with mixed-type entries, even if the list starts with a string, number, or | |||
| boolean | |||
There was a problem hiding this comment.
This should have a link to the PR.
| @@ -5,6 +5,7 @@ | |||
| /* | |||
| * Changed HashMap to LinkedHashMap for consistency. Added ability to optionally sort the lists and maps. | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
This code was borrowed from Groovy right? While we're here, we really should update the copyright notification to reflect that.
|
👍 (Once Andrew is satisfied) |
|
👍 |
Also corrected licensing for JsonSlurper
cdeszaq
force-pushed
the
fixJsonSlurpSort
branch
from
b3bd292
to
7052d0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if a list started with a
Comparable(ie. string, boolean, or number), it would be sorted using the objects' comparability. This broke if the list contained more than 1 type, like a String and a Map. With this change, that is fixed, and it should retain any sorts that existed before.Note: Only impacts test code