[addons-react] Update FluxibleMixin to check for autobind:false

[redonkulus]

If set to false, then manually bind the onChange handler.

https://github.com/yahoo/fluxible/blob/master/packages/fluxible-addons-react/FluxibleMixin.js#L116

[Vijar]

@mridgway thoughts?

We can avoid having users do the current workaround:

componentWillMount: function () {
    this.onChange = this.onChange.bind(this);
}

[mridgway]

Sure, I'm fine with this.

[mridgway]

The autobind setting is not added to the React components, it is only used during construction of the React component class. Therefore it is currently not possible to detect whether autobinding is enabled or not.

[ericf]

this.constructor.prototype.__reactAutoBindMap

Edit: This is a bad approach because it's private and might have changed in React 15.

[ericf]

@mridgway and I discussed this, and came up with some options. I think the simplest might be to just set the context to this (the component instance) when registering the event listener:

fluxible/packages/fluxible-addons-react/FluxibleMixin.js

Line 188 in d26300e

listener.store.on('change', listener.handler);

If we think the above could lead to BC breakage, we could always try to detect this pattern by updating getHandler():

getHandler: function (handler) {
    if ('string' === typeof handler) {
        handler = this[handler];
    }

    if (!handler) {
        throw new Error('storeListener attempted to add undefined handler. Make sure handlers actually exist.');
    }

    // Bind the handler to the component instance. This protects againsts:
    // `autobind: false` causing `onChange` to be called with the wrong context.
    if (handler === Object.getPrototypeOf(this).handler) {
        handler = handler.bind(this);
    }

    return handler;
},

[redonkulus]

Closing as mixins are being deprecated.