Moving to support React async mode: remove unsafe componentWillReceiveProps #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veProps with componentDidUpdate
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
fitzsimonsdevin
approved these changes
Aug 23, 2019
|
@aakula-edmunds @redonkulus any news about this one? |
|
It would be great to see this get across the line |
|
Would love to see this one! |
|
Merge this please! |
|
@redonkulus Can this be merged or any alternative solution provided? |
|
Does this warrant a major upgrade to prevent existing sites from breaking? |
|
Seems like a reasonable approach. |
|
Thanks everyone, this is released in v3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to support React async mode: get rid of unsafe componentWillReceiveProps