Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JAVA_HOME and yarn classpath to be set via configuration parameter in yaml. #54

Merged
merged 6 commits into from
Oct 4, 2013

Conversation

boneill42
Copy link
Contributor

Another fix for Issue #50. This one allows the user to set the JAVA_HOME in the yaml instead of relying on environment configuration everywhere.

@boneill42
Copy link
Contributor Author

I was hoping we could control the storm cluster from any client machine. The client machines might be configured substantially different than the server machines. (different JAVA_HOME's, different hadoop classpath's, etc.) Feel free to reject this pull request if you feel differently.

(I am now fixing it such that the hadoop classpath can be specified as well.)

@anfeng
Copy link
Contributor

anfeng commented Oct 2, 2013

Please send us a CLA form per instruction at
https://github.com/yahoo/storm-yarn/wiki/Contributing

From: boneill42 notifications@github.com
Reply-To: yahoo/storm-yarn
<reply+i-20369211-bfcee9a416311b27ea3bcfe3689b70309e0019c2-2708344@reply.git
hub.com>
Date: Tuesday, October 1, 2013 6:30 PM
To: yahoo/storm-yarn storm-yarn@noreply.github.com
Subject: Re: [storm-yarn] Allow JAVA_HOME to be set via configuration
parameter in yaml. (#54)

I was hoping we could control the storm cluster from any client machine.
The client machines might be configured substantially different than the
server machines. (different JAVA_HOME's, different hadoop classpath's, etc.)
Feel free to reject this pull request if you feel differently.

(I am now fixing it such that the hadoop classpath can be specified as
well.)


Reply to this email directly or view it on GitHub
#54 (comment) .

@boneill42
Copy link
Contributor Author

Signed and submitted.

@revans2
Copy link
Collaborator

revans2 commented Oct 4, 2013

The patch looks good to me and I can confirm we got the CLA. I am +1 on the change.

@boneill42

Can you put up a similar pull request for the 0.23 branch?

revans2 added a commit that referenced this pull request Oct 4, 2013
Allow JAVA_HOME  and yarn classpath to be set via configuration parameter in yaml.
@revans2 revans2 merged commit da7835b into yahoo:master Oct 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants