Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

memory leak bugfix unclosed error channel on http handler #39

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

kpango
Copy link
Member

@kpango kpango commented Oct 17, 2019

Signed-off-by: kpango i.can.feel.gravity@gmail.com

@kpango
Copy link
Member Author

kpango commented Jan 18, 2020

@WindzCUHK @kevindiu ping

@kevindiu kevindiu changed the title [patch] memory leak bugfix unclosed error channel on http handler memory leak bugfix unclosed error channel on http handler Jan 20, 2020
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kevindiu kevindiu force-pushed the bugfix_unclosed_error_channel branch from a75524f to d011856 Compare January 20, 2020 07:46
@codecov-io
Copy link

Codecov Report

Merging #39 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   85.83%   85.86%   +0.02%     
==========================================
  Files          14       14              
  Lines         579      580       +1     
==========================================
+ Hits          497      498       +1     
  Misses         71       71              
  Partials       11       11
Impacted Files Coverage Δ
router/debug_router.go 95.65% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e404d8...d011856. Read the comment docs.

@WindzCUHK WindzCUHK merged commit f8f38d8 into master Jan 20, 2020
@WindzCUHK WindzCUHK deleted the bugfix_unclosed_error_channel branch January 20, 2020 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants