Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

[patch] support multiple authz-bypass URLs #41

Merged
merged 13 commits into from Jan 31, 2020
Merged

[patch] support multiple authz-bypass URLs #41

merged 13 commits into from Jan 31, 2020

Conversation

WindzCUHK
Copy link
Contributor

@WindzCUHK WindzCUHK commented Jan 16, 2020

add bypass URL path for supporting PCF GSLB health check


other merged PR will be release tgt:

  1. memory leak bugfix unclosed error channel on http handler #39 (released in [patch] add go binary version during build time #43)
  2. [patch] fix lint #36 (next time)

handler/transport.go Outdated Show resolved Hide resolved
handler/transport.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #41 into master will increase coverage by 0.67%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   85.56%   86.24%   +0.67%     
==========================================
  Files          14       14              
  Lines         589      589              
==========================================
+ Hits          504      508       +4     
+ Misses         75       71       -4     
  Partials       10       10
Impacted Files Coverage Δ
config/config.go 100% <ø> (ø) ⬆️
main.go 46.05% <0%> (+2.3%) ⬆️
handler/transport.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d56eb0...866c71d. Read the comment docs.

@WindzCUHK
Copy link
Contributor Author

WindzCUHK commented Jan 17, 2020

if err := glg.Debug("Authorization checking skipped on: " + r.URL.Path); err != nil {

Not sure the level should be Debug or Warn. Discuss later.
use Info

handler/transport.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
handler/transport.go Outdated Show resolved Hide resolved
@kevindiu
Copy link
Member

Please update the example file and corresponding test case here
example_config.yaml

@WindzCUHK
Copy link
Contributor Author

Please update the example file and corresponding test case here
example_config.yaml

updated in 393a7d0

handler/transport.go Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Show resolved Hide resolved
@WindzCUHK WindzCUHK changed the title [WIP] authz-bypass [patch] authz-bypass Jan 31, 2020
@kevindiu
Copy link
Member

LGTM

@WindzCUHK WindzCUHK merged commit 0a53b77 into master Jan 31, 2020
@WindzCUHK WindzCUHK deleted the authz-bypass branch January 31, 2020 05:17
@WindzCUHK WindzCUHK changed the title [patch] authz-bypass [patch] support multiple authz-bypass URLs Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants