Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftPM support in Xcode15/Swift5.9 #22

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

simorgh3196
Copy link
Contributor

Added Swift package manager support in Xcode15/Swift5.9.
The target YJLoginSDKSampleUsingSwiftPM added for the sample can be used to check the operation.

Changes

  • Add Package.swift
  • Fix import error
    • SwiftPM requires explicit UIKit import.
  • Load images using ImageResource
    • This is to solve the Bundle problem in SwiftPM.
  • Add sample target to install the library with SwiftPM

Copy link
Contributor

@tona0516 tona0516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tona0516
Copy link
Contributor

tona0516 commented Mar 6, 2024

@simorgh3196 Sorry for the late review.
We'll publish next version included the commits in a few days!

@tona0516 tona0516 merged commit 82bdecb into yahoojapan:master Mar 6, 2024
@yagu-osakana yagu-osakana mentioned this pull request Mar 11, 2024
@tona0516 tona0516 mentioned this pull request Mar 11, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants