Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the "loading image" from Multiplayer into a reusable Widget #10262

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

SomeTroglodyte
Copy link
Collaborator

... Yes I had the urge to reuse it, and it was the trigger to that package reorg

Thing is - can' test it completely. The Widget itself is tested in FasterUIDevelopment and just fine, the in-game one renders, but of course I get no events, so... Testers?

Implementation notes:

  • Using the new kotlin time stuff, as I found extensive use of Java Duration and such a challenge must be answered. Still - needs that OptIn annotation, and Studio often is blind to it and complains. Repair IDE twice fixes that...
  • Original had Gdx Actions mixed with Coroutines - 'nah', an Action can do delays on the fly. After some XP it boiled down to one really surprisingly simple line.

@yairm210
Copy link
Owner

yairm210 commented Oct 7, 2023

If you're going to genericize this, then get rid of references to multiplayer in the loading image

@SomeTroglodyte
Copy link
Collaborator Author

Yup, slightly more parameters, but cleaner

@SomeTroglodyte SomeTroglodyte marked this pull request as draft October 7, 2023 20:23
@SomeTroglodyte
Copy link
Collaborator Author

Just so you know where this may be going:

Peek.2023-10-07.newgame.map.loading.mp4

@SomeTroglodyte SomeTroglodyte marked this pull request as ready for review November 3, 2023 23:45
@SomeTroglodyte
Copy link
Collaborator Author

Re-tested, still works.

@yairm210 yairm210 merged commit 7e35e56 into yairm210:master Nov 7, 2023
4 checks passed
@SomeTroglodyte SomeTroglodyte deleted the LoadingIconWidget branch November 7, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants