Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A ModOptions unique allowing a mod to control which map gets preselected #11468

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

SomeTroglodyte
Copy link
Collaborator

The validation is a bit over the top, we could just as well leave it at silently ignore...

That first lint is because I was looking at the lat-am mod's validation, and it has a tile improvement "Darien Gap" which seems to be supposed to incur mountain-like damage an movement penalties. Yup, should be a Terrain - feature. But: Having the ability for improvements to change those attributes could make for interesting dynamics... Food for thought.

@SomeTroglodyte
Copy link
Collaborator Author

Draft because - consider #11485 first, this might then need a merge

@SomeTroglodyte SomeTroglodyte marked this pull request as ready for review April 26, 2024 13:39
@SomeTroglodyte
Copy link
Collaborator Author

Merged forward proactively and Re-tested with the following changed ModOptions on Latam (@Caballero-Arepa):

{
    "nationsToRemove":["Rio de Janeiro"],
    "modUrl":"https://github.com/Caballero-Arepa/Latin-American_Civs",
    "author":"Caballero-Arepa",
    "lastUpdated":"2024-06-01T06:58:51Z",
    "topics":["unciv-mod","unciv-mod-expansions","unciv-mod-maps"],
    "uniques":["Cannot be used as permanent audiovisual mod", "Mod preselects map [South America B]"]
}

@Caballero-Arepa
Copy link
Contributor

That's great!

@yairm210 yairm210 merged commit 7e3bbb6 into yairm210:master Jun 4, 2024
4 checks passed
@SomeTroglodyte SomeTroglodyte deleted the MapModMapSelect branch June 4, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants