Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect "recordsTotal" returned #2613

Closed
playstation9 opened this issue Apr 14, 2021 · 2 comments · Fixed by #2614
Closed

Incorrect "recordsTotal" returned #2613

playstation9 opened this issue Apr 14, 2021 · 2 comments · Fixed by #2614

Comments

@playstation9
Copy link

Summary of problem or feature request

server-side returns incorrect "recordsTotal".

Code snippet of problem

In vendor/yajra/laravel-datatables-oracle/src/QueryDataTable.php in method count on row 211 this was added in 9.17.3:

    if (empty($builder->havings)) {
        return $builder->count();
    }

And it returns incorrect total records.

System details

  • Operating System
  • PHP Version: 7.4
  • Laravel Version: 6
  • Laravel-Datatables 9.17.3
@yajra
Copy link
Owner

yajra commented Apr 15, 2021

Count changes reverted on v9.17.4. Thanks for reporting!

@yajra
Copy link
Owner

yajra commented Apr 15, 2021

@playstation9 may we request if possible, for you to test PR #2616. Just an additional check to make sure do don't break anything this time. Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants