Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Promise Progress Notifications #21

Conversation

crazyscience
Copy link
Contributor

It uses deferred.notify() to report upload/download progress on the request module. Spent the bigger part of 3 hours trying to get tests to pass, but I couldn't for the life of me get it to work. Need to add this code into the request module mock:

var  bogusRequestModuleObject = function() {};
bogusRequestModuleObject.prototype.on = function(e, cb) {/* Fake listener registration */}; // eslint-disable-line
return new bogusRequestModuleObject();

@crazyscience
Copy link
Contributor Author

@yakovkhalinsky please advise

This was referenced Mar 4, 2017
@crazyscience
Copy link
Contributor Author

Figured it out. I forgot to implement method chaining. #amateurHour

@yakovkhalinsky
Copy link
Owner

Nice work again @crazyscience

Merging

@yakovkhalinsky yakovkhalinsky merged commit 021853a into yakovkhalinsky:master Mar 4, 2017
@yakovkhalinsky
Copy link
Owner

@crazyscience changes from your last 2 PR's are now published to npm for v0.9.12 👍

@crazyscience
Copy link
Contributor Author

👍 woo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants