Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support error throwing in feature-flag stores #132

Closed
yakovmanshin opened this issue Apr 30, 2024 · 0 comments · Fixed by #139
Closed

Support error throwing in feature-flag stores #132

yakovmanshin opened this issue Apr 30, 2024 · 0 comments · Fixed by #139
Assignees
@yakovmanshin
Labels
breaking This issue breaks compatibility with previous versions new New feature or request
Milestone
v4.0.0

Comments

@yakovmanshin
Copy link
Owner

No description provided.

@yakovmanshin yakovmanshin added new New feature or request breaking This issue breaks compatibility with previous versions labels Apr 30, 2024
@yakovmanshin yakovmanshin added this to the v4.0.0 milestone Apr 30, 2024
@yakovmanshin yakovmanshin self-assigned this May 7, 2024
This was referenced May 10, 2024
Merged
Closed
yakovmanshin added a commit that referenced this issue May 10, 2024
@yakovmanshin
[#132] Error Throwing in Feature-Flag Stores (#139)
ab7fff1 
* Extended the protocols for feature-flag stores to support error throwing in reading, writing, and removing values, and saving changes
* Updated the built-in stores
* Updated `FeatureFlagResolver`
* Updated tests
@yakovmanshin yakovmanshin mentioned this issue May 12, 2024
Merged
yakovmanshin added a commit that referenced this issue May 12, 2024
@yakovmanshin
[#130] Support for Optional Values (#143)
f78a313 
* Previously, feature-flag stores returned `nil` when the value was not found
* This behavior made it impossible to distinguish between the absence of a value and a literal `nil` value
* While this distinction wasn’t important in the majority of cases, it could be sometimes
* For that reason, optional values were not supported in YMFF
* #132 / #139 changed the protocols for feature-flag stores so they throw errors instead of returning `nil` for nonexistent values
* This change made it possible to accept `nil` as a valid feature-flag value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yakovmanshin yakovmanshin

Labels
breaking This issue breaks compatibility with previous versions new New feature or request
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

[#132] Error Throwing in Feature-Flag Stores yakovmanshin/YMFF
1 participant
@yakovmanshin