Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#130] Support for Optional Values #143

Merged
merged 4 commits into from
May 12, 2024
Merged

[#130] Support for Optional Values #143

merged 4 commits into from
May 12, 2024

Conversation

yakovmanshin
Copy link
Owner

[Closes #130]

  • Previously, feature-flag stores returned nil when the value was not found
  • This behavior made it impossible to distinguish between the absence of a value and a literal nil value
  • While this distinction wasn’t important in the majority of cases, it could be sometimes
  • For that reason, optional values were not supported in YMFF
  • Support error throwing in feature-flag stores #132 / [#132] Error Throwing in Feature-Flag Stores #139 changed the protocols for feature-flag stores so they throw errors instead of returning nil for nonexistent values
  • This change made it possible to accept nil as a valid feature-flag value

@yakovmanshin yakovmanshin added new New feature or request breaking This issue breaks compatibility with previous versions labels May 12, 2024
@yakovmanshin yakovmanshin added this to the v4.0.0 milestone May 12, 2024
@yakovmanshin yakovmanshin self-assigned this May 12, 2024
@yakovmanshin yakovmanshin merged commit f78a313 into main May 12, 2024
7 checks passed
@yakovmanshin yakovmanshin deleted the 130-optional-values branch May 12, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This issue breaks compatibility with previous versions new New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for optional values
1 participant