Merge pull request #310 from yakworks/nameCodeDescription-constraints

Name code description constraints
yakworks · Jun 15, 2021 · bc146de · bc146de
2 parents 8763944 + aca4aac
commit bc146de
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/rally-domain/src/main/groovy/yakworks/rally/common/NameCodeDescription.groovy b/rally-domain/src/main/groovy/yakworks/rally/common/NameCodeDescription.groovy
@@ -21,6 +21,6 @@ trait NameCodeDescription extends NameDescription {
     ]
 
     void beforeValidate() {
-        if(!this.name) this.name = code.replaceAll('-',' ')
+        if(!this.name && this.code) this.name = code.replaceAll('-',' ')
     }
 }
diff --git a/rally-domain/src/test/groovy/yakworks/rally/common/NameCodeDescriptionSpec.groovy b/rally-domain/src/test/groovy/yakworks/rally/common/NameCodeDescriptionSpec.groovy
@@ -17,6 +17,14 @@ class NameCodeDescriptionSpec extends Specification  implements DomainRepoTest<T
         'a-b' == tag.code
     }
 
+    void "test no code or name"() {
+        when: 'no code so cannot be created'
+        def tag = new Tag(entityName: 'Attachment')
+
+        then: 'should fail'
+        !tag.validate()
+    }
+
     void "code regex validation should succeed"() {
         when:
         def tag = Tag.create('code': 'aA12-_', name: 'tag', entityName: 'Attachment')