Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No new releases? #1095

Closed
mkellerman opened this issue Jan 6, 2020 · 35 comments
Closed

No new releases? #1095

mkellerman opened this issue Jan 6, 2020 · 35 comments
Labels

Comments

@mkellerman
Copy link

Seems like the last release dates of Nov 8, 2018. What is the status on this project? PR's are pilling up. Is this project dead?

@joshlewis
Copy link

As of today, the app (or Google?) forced me to sign out of YakYak, and I can't sign back in because the built-in "browser" is considered to be insecure by Google. So I can't use the app anymore. 👎

@mkellerman
Copy link
Author

As of today, the app (or Google?) forced me to sign out of YakYak, and I can't sign back in because the built-in "browser" is considered to be insecure by Google. So I can't use the app anymore. 👎

Check for a fix here: #1087 (comment)

Hence why a new release would be nice, that includes the fix...

@joshuacant
Copy link

Seems like the maintainer has moved on, it happens. Has anyone forked this yet and incorporated all the changes from the last couple years into a new build?

@mkellerman
Copy link
Author

I can help setup a new fork, and create a build in Azure and such.. but I’m no dev. I would be useless to approve/comment on PRs.

Would be nice if the maintainer could give us a status update. I’ve seen recent commits being done, but no releases.

@joshuacant
Copy link

The most recent commits are from Jan/Feb of 2019, which is basically a year ago, so it has been quite a while since there was activity. I don't mean any of this as an attack on the current maintainer. Things happen, interests change, time moves on. It probably didn't help motivation any when Google cancelled and then un-cancelled Hangouts in 2019.

I think someone taking the project on would need to be able to manage incoming PRs and doing builds for MacOS, Linux, and Windows. Either that, or split the duties between a couple people.

@atomicwrites
Copy link

atomicwrites commented Jan 20, 2020

I thought it said he had stopped maintaining it since hangouts was deprecated, but i don't see it now.

@averissimo
Copy link
Member

Sorry about that, but I'm no longer actively maintaining yakyak.

Both me and the previous developer stopped using hangouts and if someone wants to step up I gladly give him permissions.. (or ask the previous dev to give it)

I'm merging pending PR requests and will be updating the internal packages it uses.

I'm hoping to release a new version today.

This is all I can do.

@averissimo
Copy link
Member

New release is available at v1.5.4-beta-rolling

I'd like if someone could test it for a bit to see if everything works fine.

I'll wait until users in Windows and Mac say that it's working for them.

What to look for:

  • Notification problems
  • Window problems (electron, the framework used under yakyak was updated to a much more recent one)

If I have the ok, this will be "officially" released.. maybe #1096 can also be included

@mkellerman
Copy link
Author

I downloaded and installed on macOS. Seems fine. Is there a special list of features to test?

@averissimo
Copy link
Member

There's a new message menu entry from pull request #1043 which is the only new feature if I'm not mistaken (besides translations)

Check if your normal workflow has any problems and keep an eye on notifications for anything different.

There were some updates to external packages that were quite big, unfortunately we don't have a testing framework in place to reliably check for problems.

@averissimo
Copy link
Member

Btw, as a Mac user you can give feedback to this pull request from a while ago #1042

Seems like there could be a conflict on the change... if you care to share your opinion please comment there. That's the sort of change I can do for this release.

@joshuacant
Copy link

Thank you for the new build, André. It's above and beyond given the status of the project, and definitely appreciated. I've upgraded and will report back after a couple days of normal use.

@mkellerman
Copy link
Author

Btw, as a Mac user you can give feedback to this pull request from a while ago #1042

Seems like there could be a conflict on the change... if you care to share your opinion please comment there. That's the sort of change I can do for this release.

Just commented on the issue. We should use the macOS standard way.

@mkellerman
Copy link
Author

I second @joshuacant, Thanks!

@survivor303
Copy link
Contributor

so the 1.5.4 code is new? release date is still from 2018, so little bit confusion there ;)

@atomicwrites
Copy link

@survivor303 The way I understand it's that is not the 1.5.4 release, but the permanently updated "master branch" code that would eventually be 1.5.4. The release was made in 2018 but the files are updated each time there is a change. At least that's what I understand.

@averissimo
Copy link
Member

Yup, that was the idea under naming rolling release, instead of having multiple "beta" releases polluting the page.

Just pushed a new version with some of my old pull requests that I was hoping someone would review them

  • Hides archived conversations
  • Corrects a problem when deleting conversations

@joshuacant
Copy link

Hiding archived conversations works here. I've been wanting that feature for ages!

@averissimo
Copy link
Member

Bunch on new code that cleans work from previous pull requests that were "merge-able". I couldn't get in deep on the on_the_record / off_the_record :(

Notable changes:

  • Underlying fix for "Google Couldn't sign you in Yakyak"
  • Hides archived conversations
  • Add 'Show image preview' (feature Option to disable Inline Pictures #620) -- pull request Add 'Show image preview' feature #620 #1096
    • only for previewing sent links (not for images shared via hangouts)
  • Corrects a problem when deleting conversations
  • New conversation menu
  • When adding users to a conversation it shows the email when hovering the avatar
  • Should correct a notification problem in Windows 10
  • Should correct an auto-launch bug on macOS
  • Bunch on updates on packages that will provide with better security and hopefully same functionality
  • Fix mapping to 💩
  • Adds languages
    • Telugu
    • Breton
    • Simplified chinese
    • Remaning Czech string
  • Moved my name to the "Main authors", because of Ego

Maybe some others... Didn't track everything ¯\_(ツ)_/¯

I ask the very patient community to please report if there are any problems. Plan on releasing the v1.5.4 in 24h from this comment.

@mkellerman
Copy link
Author

Is there a way for me to send you a donation for your work? Buy you a beer or something? I/we really appreciate this!

@averissimo
Copy link
Member

I may get the visibility, but the majority of the work goes to the still existing community

@AlessSala @signedbit @Jhall1990 @michaelherold @adrienlucas plus others with translations (counting only for this release).

If you are keen on donating that beer please consider one of them or you favorite charity 😄

@ryantiger658
Copy link
Contributor

ryantiger658 commented Jan 26, 2020

@averissimo, thanks so much for merging these PR's and doing a release! I appreciate your temporarily coming out of retirement for this.

I am a DevOps engineer and not a JavaScript developer, but I am happy to volunteer to be an interim maintainer until I can hand it off to a no-kidding JS developer. I am currently maintaining a couple of other OS projects.

I would be able to setup a CI/CD pipeline for some automated releases, testing, and such. And I know enough JS to do code reviews.

I just figured I would offer so that you can officially retire and not have to get dragged back in! :)

@survivor303
Copy link
Contributor

If we can get 24h timeformat available for what ever region user might be.

@ryantiger658
Copy link
Contributor

1.5.4-beta is not working on Ubuntu 64bit. Trying to dig up a log file. Basically It keeps opening new windows without actually displaying anything.

@Jhall1990
Copy link

1.5.4-beta is not working on Ubuntu 64bit. Trying to dig up a log file. Basically It keeps opening new windows without actually displaying anything.

Seeing the same thing on MacOS. It was working until I signed out and tried to sign back in. Then I saw the above behavior.

@ryantiger658
Copy link
Contributor

ryantiger658 commented Jan 27, 2020

Getting a whole bunch of "AGENT is not defined"


> yakyak@1.5.4 dev /home/ryantiger658/Projects/yakyak
> electron app --debug

Installing Devtron from /home/ryantiger658/Projects/yakyak/app/node_modules/devtron
hconnect
reconnecting 0
resolving proxy http://plus.google.com
resolving proxy https://plus.google.com
resolved proxy DIRECT
resolved proxy DIRECT
2020-01-27 11:51:41 DEBUG emit connecting 
DEBUG: Received event connecting
2020-01-27 11:51:41 DEBUG getting auth...
2020-01-27 11:51:41 DEBUG proceeding to login
asking for login credentials
2020-01-27 11:51:41 DEBUG request auth code from user
2020-01-27 11:51:41 ERROR getAuth failed ReferenceError: AGENT is not defined
    at /home/ryantiger658/Projects/yakyak/app/login.js:43:22
    at Function.promise (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:702:9)
    at module.exports (/home/ryantiger658/Projects/yakyak/app/login.js:16:14)
    at Auth.creds (/home/ryantiger658/Projects/yakyak/app/main.js:274:14)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/hangupsjs/lib/auth.js:129:24
    at _fulfilled (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:854:54)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:883:30
    at Promise.promise.promiseDispatch (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:816:13)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:877:14
    at runSingle (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:137:13)
2020-01-27 11:51:41 DEBUG emit connect_failed ReferenceError: AGENT is not defined
    at /home/ryantiger658/Projects/yakyak/app/login.js:43:22
    at Function.promise (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:702:9)
    at module.exports (/home/ryantiger658/Projects/yakyak/app/login.js:16:14)
    at Auth.creds (/home/ryantiger658/Projects/yakyak/app/main.js:274:14)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/hangupsjs/lib/auth.js:129:24
    at _fulfilled (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:854:54)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:883:30
    at Promise.promise.promiseDispatch (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:816:13)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:877:14
    at runSingle (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:137:13)
connect_failed ReferenceError: AGENT is not defined
    at /home/ryantiger658/Projects/yakyak/app/login.js:43:22
    at Function.promise (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:702:9)
    at module.exports (/home/ryantiger658/Projects/yakyak/app/login.js:16:14)
    at Auth.creds (/home/ryantiger658/Projects/yakyak/app/main.js:274:14)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/hangupsjs/lib/auth.js:129:24
    at _fulfilled (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:854:54)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:883:30
    at Promise.promise.promiseDispatch (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:816:13)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:877:14
    at runSingle (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:137:13)
DEBUG: Received event connect_failed
error connecting ReferenceError: AGENT is not defined
    at /home/ryantiger658/Projects/yakyak/app/login.js:43:22
    at Function.promise (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:702:9)
    at module.exports (/home/ryantiger658/Projects/yakyak/app/login.js:16:14)
    at Auth.creds (/home/ryantiger658/Projects/yakyak/app/main.js:274:14)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/hangupsjs/lib/auth.js:129:24
    at _fulfilled (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:854:54)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:883:30
    at Promise.promise.promiseDispatch (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:816:13)
    at /home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:877:14
    at runSingle (/home/ryantiger658/Projects/yakyak/app/node_modules/q/q.js:137:13)```

@ryantiger658
Copy link
Contributor

It looks like one of the additional PR's conflicted out a couple of lines from #1092. I can submit a PR with the fixed code.

# Credit to https://github.com/yakyak/yakyak/issues/1087#issuecomment-565170640
AGENT = "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/80.0.3904.70 Safari/537.36"

@joshuacant
Copy link

There may be something weird going on with the bubble showing unread message count. I've been seeing weird values all day, but here's just one example. It says "20+" but there was only 1 unread message, because it's a conversation I've been active in all morning.

notif

@ryantiger658
Copy link
Contributor

ryantiger658 commented Jan 27, 2020

So in local testing updating the login.coffee file fixed the startup issue. However, now once I login I hang on a "One moment please..." message with no obvious errors in the log

login: did-finish-load https://accounts.google.com/o/oauth2/programmatic_auth?hl=en&scope=https://www.google.com/accounts/OAuthLogin+https://www.googleapis.com/auth/userinfo.email+[secret stuffs]
login: programmatic auth

(redacted what I assume are some secrets)

This is the content for login.coffee that I used. https://raw.githubusercontent.com/signedbit/yakyak/909638221e311bcf0a815fc808884f043be71eff/src/login.coffee

@averissimo
Copy link
Member

averissimo commented Jan 28, 2020

@ryantiger658 and @Jhall1990 Oopsie... problem resolved in a less static way by replacing "Chrome" with "Chromium" in the default user agent. Even with Electron 8.0.0-beta.6 it still shows the same -_- I guess not even Chrome 80.* is safe for Google

Hopefully in the medium term this "fix" can be removed.

@joshuacant I can't replicate this issue. Does it show immediately or just when the conversation is being ghosted for a while?

@survivor303 does the option "Edit" -> "Use system date format" works?

image

@averissimo
Copy link
Member

in my system -- Ubuntu -- I have 24h defined in the calendar and it shows like the image.. Otherwise it says 5:18PM

@joshuacant
Copy link

If that notification count glitch is only happening to me, I'll try wiping my settings folder and logging in fresh. That might fix it, or if not I can live with it. It's a very minor issue.

@billchase2
Copy link

I just came across this project and am thrilled to see that there have been some recent updates. Thank you! It's just what I've been looking for on my Mac. Working great, so far.

@averissimo
Copy link
Member

@joshuacant it's not only happening to you, check out #1109

@stale
Copy link

stale bot commented Mar 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants