Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable Inline Pictures #620

Open
cron410 opened this issue Mar 9, 2017 · 7 comments
Open

Option to disable Inline Pictures #620

cron410 opened this issue Mar 9, 2017 · 7 comments

Comments

@cron410
Copy link

cron410 commented Mar 9, 2017

This feature would be very useful for when using Yakyak in the workplace.

@cron410
Copy link
Author

cron410 commented Sep 18, 2017

Closed due to inactivity?

@averissimo
Copy link
Member

averissimo commented Sep 18, 2017

yes, the bot went crazy today, please reopen any other issues that you believe have been mistakenly closed :)

@averissimo averissimo reopened this Sep 18, 2017
@stale stale bot removed the inactive label Sep 18, 2017
@stale
Copy link

stale bot commented Nov 17, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Nov 17, 2017
@cron410
Copy link
Author

cron410 commented Jan 15, 2018

+1

@stale stale bot removed the inactive label Jan 15, 2018
@averissimo
Copy link
Member

Can you be a little more descriptive on what you are asking?

@stoppablemurph
Copy link

I think the requester (and me) would like an option to not show images received by default. Some sort of show/hide functionality (with a configurable default state) would be perfect. It's kind of awkward when I'm at work and my sister starts spamming baby pictures in our family's group chat.

@averissimo
Copy link
Member

This can be probably achieved by adding a new option and changing the code in messages.coffee

# image formatter
    (seg) ->
        href = seg?.link_data?.link_target
        imageUrl = getImageUrl href # false if can't find one
        if imageUrl and preload imageUrl
            div ->
                img src: imageUrl

with a if clause that checks the option and instead of outputing a img tag it outputs a link tag saying it is an image

AlessSala pushed a commit to AlessSala/yakyak that referenced this issue Jan 8, 2020
Available in Menu->View->Show image preview .
It is possible to toggle the image preview with
CTRL+P keyboard combination.
averissimo added a commit that referenced this issue Jan 26, 2020
AlessSala pushed a commit to AlessSala/yakyak that referenced this issue Jan 27, 2020
This is a feature yakyak#620 follow-up.
A new i18n string is added: 'hidden_img_click_to_open'.
AlessSala added a commit to AlessSala/yakyak that referenced this issue Jan 29, 2020
This is a feature yakyak#620 follow-up.
A new i18n string is added: 'no_preview_image_click_to_open'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants