Unread badge remaining after read

[driph]

Mac OS Catalina 10.15.7
Yakyak v1.5.10

Badges in both the app window and the dock icon continue to persist once a message has been read. Replying to the message clears the badge.

Interestingly, the problem is not consistent. I'll add more if I can figure out what causes it to persist and clear.

Not seeing this behavior on a second machine running Big Sur.

[teicher]

confirming same behaviour (also MacOS Catalina, 1.5.10)

[vasudev-gm]

Can confirm the issue exits on Xubuntu (Ubuntu derivative) 20.04.
If I read the message in Google Hangouts on a browser the read receipt is updated instantly.

[zackotronic]

can confirm that this occurs on macOS Big Sur

[shapirc]

Can confirm this occurs with Yakyak v1.5.10 on Windows 10.0.19041

[kingkool68]

The fix in the v1.5.11-beta release resolves this issue (MacOS 11.1)

[driph]

The fix in the v1.5.11-beta release resolves this issue (MacOS 11.1)

It does! Heh, although now, in v1.5.11-beta, the unread badge is gone entirely.

Update: spoke too soon, some group messages don't show badges at all, but another message is showing the same unread badge behavior as 1.5.10.

[averissimo]

@HomerSp do you think this is a side effect of #1275 or is it something unrelated?

[HomerSp]

@averissimo I first thought it may be because of that, but I've looked into it now and I can say that it isn't. It's because they've changed self_conversation_state.self_read_state.latest_read_timestamp to a string, which causes the unread method in conv to return 0 because it checks if the type of latest_read_timestamp is a number.
We can either just fix it in yakyak by calling parseInt in the unread method. But I can see it's being used by other methods too, so a better solution might be to modify hangupsjs instead and add a new NumberField (that calls parseInt) to pblite and have latest_read_timestamp use that instead of just a regular Field.

I've tested both solutions and they work, but the latter would probably be a better approach. Let me know what you think and I'll do a PR.

[averissimo]

I would say that the latter solution would be better as this is a protocol change, but we'll merge what you think is best.

[HomerSp]

@averissimo PR here: yakyak/hangupsjs#119 :)

[averissimo]

@HomerSp Works like a charm in current master. @driph (and or others) can you test v1.5.12-beta-rolling ?

[driph]

Will do, pulling it down now.

[driph]

It seemed fixed for a couple hours, but just received a message on a group conversation with a stuck badge.. replying to it cleared the indicator.

[HomerSp]

It seemed fixed for a couple hours, but just received a message on a group conversation with a stuck badge.. replying to it cleared the indicator.

Shame, I'll need to see if I can reproduce it on my end. Just to clarify, do you mean that the unread state sometimes gets stuck - ie, the tray icon shows an unread message, the conversations list shows the unread count and the message is in bold? And when you click the conversation it doesn't register as being read? Does going to another conversation and then back again work, or if you close yakyak and reopen? Or is the only way to get it back to normal by replying to the message? Thanks

[driph]

When it happens, the dock icon shows an unread message, the conversations list shows the unread count, and the message is in bold. Clicking the message, the dock icon, or cycling between messages doesn't change the state. Closing yakyak and reopening it, replying, or viewing the message on Hangouts all resolve the incorrect state.

[pfoufoutis]

FYI this issue still persists
Macbook (2015) Big Sur 11.1, YakYak v1.5.10

[kupavcev]

issue still persists
Macbook (mid 2014) 10.14.6 (18G95), YakYak YakYak v1.5.12-beta (latest)

little later:
Just installed v1.5.11-rolling-beta(b25f2b0) - looks like there is no this bug.

little later:
After 2 hours - the same bug in v1.5.11-rolling-beta(b25f2b0), I don`t know why it worked earlier.

[smartinec]

As others mentioned above, it appears that YakYak is not actually marking the message as "read" since it remains unread on other apps/devices.

[fabiendelpierre]

macOS Catalina 10.15.7 + YakYak 1.5.11 here... the issue has mysteriously gone away.

Edit: actually it comes and goes? I'm not seeing any pattern 😐

[zanthorn]

Still seeing this on and off on 1.5.11 and Big Sur 11.2.1

[brihh]

still seeing this, intermittently (can't really isolate what's common about when it's working and when it's broken ..)

1.5.11.3 (snap) on Ubuntu 20.04.2 LTS

[smartinec]

Any further update on this issue as it's still occurring on YakYak v1.5.11.5 on MacOS Big Sur 11.6?