Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangouts logo on splash screen changes size on star up #471

Closed
mosbror opened this issue Dec 2, 2016 · 11 comments
Closed

Hangouts logo on splash screen changes size on star up #471

mosbror opened this issue Dec 2, 2016 · 11 comments
Assignees
Labels

Comments

@mosbror
Copy link

mosbror commented Dec 2, 2016

This is really a minor bug.
The Hangouts logotype on the splash screen changes size when switching between "Connecting" and "Loading contacts".

yakyak_ssize.mov.zip

@averissimo averissimo added the bug label Dec 2, 2016
@averissimo
Copy link
Member

it doesn't on linux

cool catch :)

@averissimo averissimo self-assigned this Dec 2, 2016
averissimo added a commit that referenced this issue Dec 2, 2016
Fix image loading resizing -- #471

small and contained fix
@averissimo
Copy link
Member

corrected in pull request #472

thanks for reporting 👍

@averissimo
Copy link
Member

@mosbror actually, can you test if the fix works?

Find the binary here:

https://github.com/averissimo/yakyak/releases/download/test-icon/yakyak-472-1.4.0-darwin-x64.zip

@averissimo averissimo reopened this Dec 2, 2016
@averissimo
Copy link
Member

actually, that can be a result of having a different zoom level set in yakyak

can you confirm that happens if zoom is at 100% (ctrl+0) ?

@averissimo averissimo reopened this Dec 2, 2016
@Silveran
Copy link

Silveran commented Dec 3, 2016

It works well for me with your version, just a little drop of the logo margin-top (not its size),it seems that the "Loading contacts" wording changes its font-size during the splashscreen.

splashscreen.mov.zip

@averissimo
Copy link
Member

i can't fix this blindly, seems like in Mac OS X the relative fonts and margins are changed just after connecting.

Can't reproduce this is linux or windows 7

needs someone to look at this :)

@Silveran
Copy link

Silveran commented Dec 3, 2016

It's much better than before with your patch, don't worry, it's not important ;)

@mosbror
Copy link
Author

mosbror commented Dec 3, 2016

I agree with Silverian.

@averissimo
Copy link
Member

That's the first thing new users actually see when they try YakYak, should be clean :)

Can you try this: https://github.com/averissimo/yakyak/releases/tag/sandbox

@Silveran
Copy link

Silveran commented Dec 4, 2016

@averissimo It works, you rock !!

@averissimo
Copy link
Member

PR #477

Thanks for reporting and feedback, closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants