Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra window titlebar now visible on macOS in v1.5.2 #976

Closed
cgatesman opened this issue Oct 21, 2018 · 5 comments
Closed

Extra window titlebar now visible on macOS in v1.5.2 #976

cgatesman opened this issue Oct 21, 2018 · 5 comments

Comments

@cgatesman
Copy link

After upgrading from 1.5.1 to 1.5.2, Yakyak now has an extra visible native title bar in macOS Mojave:

screen shot 2018-10-21 at 12 56 07 pm
@varystargaryen
Copy link

Same issue present on 1.5.2 while running macOS Mojave Version 10.14.1 Beta (18B67a).
image

@zanthorn
Copy link

zanthorn commented Oct 26, 2018 •
edited

I have the same issue on Mojave and 1.5.2 installed this morning.

@edraven
Copy link

edraven commented Oct 26, 2018

Same with 1.5.2 on High Sierra

@ghost
Copy link

ghost commented Oct 27, 2018

I am also experiencing this on macOS Mojave.

@ztoben ztoben mentioned this issue Oct 29, 2018
Merged
@ztoben
Copy link
Contributor

ztoben commented Oct 29, 2018 •
edited

I have a pr out for this, hopefully gets merged soon.

If you want to fix this on your local version, edit your main.js file on line 206. Change 'hidden-inset' to 'hiddenInset'.

New line will look like this:

titleBarStyle: process.platform === 'darwin' ? 'hiddenInset' : void 0,

Should fix it until a new release is rolled out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@edraven @ztoben @cgatesman @varystargaryen @zanthorn